search

NatLibFi / Skosmos

Thesaurus and controlled vocabulary browser using SKOS and SPARQL
Other
224 stars 94 forks source link

[Issue] Compatability issues with upgrading skosmos version #1376

Open YOUR1 opened 1 year ago

YOUR1 commented 1 year ago

We have edited the default twig files in the view/ folder to be more inline with our own/clients layouts. We customised the skins at skosmos version v2.9. When upgrading to v2.15 we encountered several versions, including the bootstrap version was upgraded to v5. I believe this is an issue due the fact we are upgrading to a patch version. In my believe, major releases should include this kind of version bumps, and not minor versions.

Ofcourse; it's never wise to edit twig files itself; but that's another issue: https://github.com/NatLibFi/Skosmos/issues/1375

osma commented 1 year ago

I'll repeat and rehash what I said in https://github.com/NatLibFi/Skosmos/issues/1375#issuecomment-1271358351:

Regarding the Bootstrap change: I'm sorry this has caused pain for you, but it was really overdue and had to be done, just like the jQuery upgrade and related changes in the newly released 2.16. We have tried to point out in the Release Notes when there are important changes in the UI layer that affect customized installations.

We have started planning for a future 3.0 release where the UI layer would likely be rebuilt entirely. The details are still being worked out. Making templates easier to customize could be considered, but they are an important part of the application and need to evolve together with the rest of the code base.