miguelvaara commented 5 months ago

Reasons for creating this PR

Implemented axe-about.cy.js test to improve accessibility.

Link to relevant issue(s), if any

1582.

Closes #

Description of the changes in this PR

Fixes the code where it had issues pointed out by the Axe tool on the About page.

Intstructions to the reviewer: Just run the Cypress test like you usually do and focus on checking the accessibility test for the About page.

Known problems or uncertainties in this PR

-

Checklist

[x] phpUnit tests pass locally with my changes
[x] I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
[x] The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
[x] The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2c0a8f7) 70.54% compared to head (f81b3eb) 70.54%. Report is 2 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1593 +/- ## ========================================= Coverage 70.54% 70.54% Complexity 1644 1644 ========================================= Files 32 32 Lines 4315 4315 ========================================= Hits 3044 3044 Misses 1271 1271 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

osma commented 5 months ago

I noticed that the CI run cypress-test (push) had failed, probably for unrelated reasons, but I restarted it just in case to verify that it was just a transient failure. EDIT: Yes, it was just a transient failure, on the 2nd run the test passed.

sonarcloud[bot] commented 5 months ago

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

NatLibFi / Skosmos

Enable Axe accessibility tests for about page #1593