NatLibFi / Skosmos

Thesaurus and controlled vocabulary browser using SKOS and SPARQL

Other

218 stars 94 forks source link

Copy to clipboard button for notations #1614

Closed joelit closed 2 months ago

joelit commented 3 months ago

Reasons for creating this PR

This PR replicates Skosmos 2 -style function of using the copy to clipboard button in the title to copy the notation code if one exists.

Link to relevant issue(s), if any

1484

Description of the changes in this PR

Known problems or uncertainties in this PR

Accordding to Skos spec, a concept can have several notations. We don't have such a vocabulary, but in such case there is no spec for Skosmos to follow - which notation(s) are shown in the title, and what should the copy to clipboard buttom return in such case.

Checklist

[X] phpUnit tests pass locally with my changes
[X] I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
[X] The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
[X] The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.58%. Comparing base (9d30c49) to head (23067b9). Report is 2 commits behind head on main.

:exclamation: Current head 23067b9 differs from pull request most recent head 0ffa92a. Consider uploading reports for the commit 0ffa92a to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1614 +/- ## ========================================= Coverage 70.58% 70.58% Complexity 1647 1647 ========================================= Files 32 32 Lines 4321 4321 ========================================= Hits 3050 3050 Misses 1271 1271 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

joelit commented 3 months ago

Rebased and force-pushed

sonarcloud[bot] commented 3 months ago

Quality Gate failed

Failed conditions
52.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

sonarcloud[bot] commented 2 months ago

Quality Gate failed

Failed conditions
52.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud