Fixed accessibility issues reported by Cypress and added variables to Twig templates indicating the loaded template (issue1582)

NatLibFi / Skosmos

Thesaurus and controlled vocabulary browser using SKOS and SPARQL

Other

224 stars 94 forks source link

Fixed accessibility issues reported by Cypress and added variables to Twig templates indicating the loaded template (issue1582) #1615

Closed miguelvaara closed 5 months ago

miguelvaara commented 6 months ago

Reasons for creating this PR

Accessibility is important and also a required aspect for us, so we demand accuracy from test automation.

Link to relevant issue(s), if any

Closes #1582

Description of the changes in this PR

Added a variable to each Twig template indicating which template has been loaded, in order to better conditionally display/use code blocks.
Fixed accessibility issues identified by Cypress-AXE.
Verified the coding style.

Known problems or uncertainties in this PR

Checklist

[x] phpUnit tests pass locally with my changes
[x] I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
[x] The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
[x] The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

sonarcloud[bot] commented 6 months ago

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.58%. Comparing base (9d30c49) to head (92551ce). Report is 2 commits behind head on main.

:exclamation: Current head 92551ce differs from pull request most recent head 498cdec. Consider uploading reports for the commit 498cdec to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1615 +/- ## ========================================= Coverage 70.58% 70.58% Complexity 1647 1647 ========================================= Files 32 32 Lines 4321 4321 ========================================= Hits 3050 3050 Misses 1271 1271 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 5 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

miguelvaara commented 5 months ago

Thank you @osma for many good advices and for participating.