Make LOC HTTP prefLabel header parsing case-insensitive (Skosmos 2) - Githubissues

NatLibFi / Skosmos

Thesaurus and controlled vocabulary browser using SKOS and SPARQL

Other

218 stars 94 forks source link

Make LOC HTTP prefLabel header parsing case-insensitive (Skosmos 2) #1621

Closed osma closed 2 months ago

osma commented 2 months ago

Reasons for creating this PR

Fix LCSH label lookups by making HTTP header parsing case-insensitive. See #1619 This PR backports the fix from Skosmos 3 to Skosmos 2.

Link to relevant issue(s), if any

Closes #1619 (for Skosmos 2)

Description of the changes in this PR

Make LOC HTTP prefLabel header parsing case-insensitive in LOCResolver.php

Known problems or uncertainties in this PR

n/a

Checklist

[x] phpUnit tests pass locally with my changes
[x] I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
[x] The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
[x] The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

sonarcloud[bot] commented 2 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud