Search result tweaks for autocomplete - Githubissues

NatLibFi / Skosmos

Thesaurus and controlled vocabulary browser using SKOS and SPARQL

Other

224 stars 94 forks source link

Search result tweaks for autocomplete #1623

Closed joelit closed 5 months ago

joelit commented 5 months ago

Link to relevant issue(s), if any

1514

Description of the changes in this PR

Filtered duplicate results with unique=true parameter. This changes the amount of search results recieved
Alternate labels are displayed in italics
Notation codes are shown if showNotation configuration parameter is set for the vocabulary
Notation code results are returned and bolded if they match the search term

Known problems or uncertainties in this PR

The language for the search is not set yet. That fuctionality should come in the follow-up pull request.

Checklist

[x] phpUnit tests pass locally with my changes
[x] I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
[x] The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
[x] The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

sonarcloud[bot] commented 5 months ago

Quality Gate failed

Failed conditions
37.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud