joelit commented 2 months ago

Link to relevant issue(s), if any

1514

Description of the changes in this PR

This PR produces translation strings in WebController for different class URIs. Autocomplete result list can then present human readable labels for the types of search results.

Known problems or uncertainties in this PR

Checklist

[x] phpUnit tests pass locally with my changes
[x] I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
[x] The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
[x] The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

sonarcloud[bot] commented 2 months ago

Quality Gate failed

Failed conditions
28.9% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

osma commented 2 months ago

Looks like a good start.

Regarding terminology: I think conceptTypeTranslations or typeTranslations is potentially misleading. Some of the type labels come from translations, others from the vocabulary data. How about typeLabels or just types, depending on the context?

NatLibFi / Skosmos