Skosmos 2: Fix PHP 8.1 deprecation message that broke content language links - Githubissues

NatLibFi / Skosmos

Thesaurus and controlled vocabulary browser using SKOS and SPARQL

Other

229 stars 95 forks source link

Skosmos 2: Fix PHP 8.1 deprecation message that broke content language links #1702

Closed osma closed 1 month ago

osma commented 1 month ago

Reasons for creating this PR

PHP deprecations warnings may break content language switching links. See #1701

This PR fixes the problem by ensuring that str_replace cannot be called with a null value as the third parameter.

Link to relevant issue(s), if any

Closes #1701

Description of the changes in this PR

check for null values before calling str_replace in Vocabulary->getLocalName()

Known problems or uncertainties in this PR

Maybe should be done for Skosmos 3 as well, just in case?
No unit test, sorry

Checklist

[x] phpUnit tests pass locally with my changes
[ ] I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
[x] The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
[x] The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

sonarcloud[bot] commented 1 month ago

Quality Gate failed

Failed conditions
57 Security Hotspots
C Maintainability Rating on New Code (required ≥ A)
D Reliability Rating on New Code (required ≥ A)
E Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint