search

NatLibFi / koha-plugin-rest-di

REST API plugin for Koha to provide additional functionality for discovery interfaces such as VuFind
GNU General Public License v3.0
9 stars 9 forks source link

Fix compatibility with Koha 23.05 (22.12) #27

Closed sl18 closed 1 year ago

sl18 commented 1 year ago

Modified function calls to handle different Koha versions:

EreMaijala commented 1 year ago

Latest version now branched to Koha-22.05 branch.

nugged commented 1 year ago

I suspect that the version bump and change of CanBookBeRenewed did not happen at the same moment, which makes the version check not work for any interim versions.

@EreMaijala - with these changes in this PR plugin becomes "future-compatible" so can be installed on older Koha's before the upgrade, then when Koha gets upgraded it starts to work with new calling ways...

Or what is your concern, can you rephrase, please?

EreMaijala commented 1 year ago

@nugged The version string isn't equal to the moment the method was changed. So if you install the plugin with a Koha (dev) version that's later than 22.11 but before the the change, it won't work, and there's no way to make it work.

nugged commented 1 year ago

@sl18 let's make 23.05-only (no 22.11 compatibility) version into master then.

sl18 commented 1 year ago

Done. And also removed the Koha version check for checkpw_internal in PatronController.pm

nugged commented 1 year ago

ah! @sl18 And we need to increase the minimum version in the plugin body.

EreMaijala commented 1 year ago

@nugged I can do that while I add a change log and update the README.

nugged commented 1 year ago

@EreMaijala, that's not trivial; anyway, it can't be 23.05 otherwise it won't work for us now in "prerelease" builds.

we found the closest 22.12.00.036 there https://github.com/NatLibFi/koha-plugin-rest-di/pull/28