search

NatLibFi / koha-plugin-rest-di

REST API plugin for Koha to provide additional functionality for discovery interfaces such as VuFind
GNU General Public License v3.0
9 stars 9 forks source link

Missing methods #35

Closed fridobox closed 3 months ago

fridobox commented 4 months ago

Hi,

A plugin should always define methods install, upgrade and uninstall, even empty. Indeed they are called and must return 1 to say OK.

See for example: https://github.com/biblibre/koha-plugin-theme-intranet-lsd/commit/5bd213ba966aa88ee875a6b4a8faf3b3eb8ca882

And: https://github.com/bywatersolutions/koha-plugin-coverflow/blob/master/Koha/Plugin/Com/ByWaterSolutions/CoverFlow.pm#L201

EreMaijala commented 4 months ago

@fridobox Thanks! Shouldn't these be documented also in the plugin development reference?