Query database instead of using external API

[natlibfi-arlehiko]

Description

Currently retrieving records is done using voyager-record-fetch-cgi. This requires an external service. The current implementation of the service also has a bug which sometimes prevents the record from being updated (Although Batchcat DLL doesn't report an error but the record isn't updated).

Using a direct SQL connection to Voyager database removes the need to use an external service and allow the bug to be fixed in this codebase.

Specification

Configuration

Configuration file (fetchApi property is no longer needed)

{
  "port": 1337,
  "iniFile": "/foo/bar/voyager.ini",
  "externalUrl": "https://foo.bar/api",
  "db": {
    "connectString": "VGER",
    "username": "foo",
    "password": "bar"
  }
}

Environment variables

• TNS_ADMIN: Path to tnsnames.ora (See aleph-change-listener on how this is configured

  Implementation

  1. Fetching data
  2. Record data is requested: SELECT marc_record FROM foodb.bibblob_vw WHERE bib_id = 124567
     1. If the record's last update time is requested: SELECT create_date,update_date FROM bib_master WHERE bib_id = 1234567;
     2. MARC record object is created from the retrieved data: MarcRecord.fromString(data)
  3. Record history is requested: SELECT action_date, location_id, action_type_id, e, s FROM foodb.bib_history WHERE bib_id = 124567 ORDER BY action_date desc
     1. The data is converted to JSON:
        • action_date -> date: moment(value, 'DD.MM.YYYY HH:mm:ss').format()
        • location_id -> location: Number.parseInt(value)
        • action_type_id -> type: Number.parseInt(value)
        • e -> encodingLevel: Number.parseInt(value)
        • s -> opacSuppress: value === 'Y' ? true : false
  4. The record is returned unless the last update time was requested as well: { record: [MarcRecord], lastUpdateTime: [Date] }
  5. If the record is to be updated, the last update time is passed on to voyager-batchcat-js because the value fetched from the record's 005 may be out of sync. This depends on natlibfi/voyager-batchcat-js#2.