Morning session: peer-to-peer code reviews

NatanimA / Microverse-Portfolio-Project

A portfolio project was done with HTML, CSS, and plain Javascript, which will be updated occasionally until it meets the desired design.

https://github.com/NatanimA/Microverse-Portfolio-Project.git

8 stars 0 forks source link

Morning session: peer-to-peer code reviews #8

Open ManarOmari opened 2 years ago

MaiRizk commented 2 years ago

Great job overall, I just see a few things that can make your website look better;

Making the navbar fixed makes it look excellent while scrolling but I suggest giving the header position sticky instead, it will make the default view better.
The website looks fantastic in the mobile version and the box shadow for the cards makes it look great. However, it breaks at 768px width screen so I suggest either making your card width get larger when the screen gets bigger or adding a media query for tablet and another one for desktop.

NatanimA commented 2 years ago

Great job overall, I just see a few things that can make your website look better;

Making the navbar fixed makes it look excellent while scrolling but I suggest removing the white background from the default view and adding it only while scrolling.

The website looks fantastic in the mobile version and the box shadow for the cards makes it look great. However, it breaks at 768px width screen so I suggest either making your card width get larger when the screen gets bigger or adding a media query for tablet and another one for desktop.

Thank you mai, I will make the changes according to your suggestions. 😄 .

ManarOmari commented 2 years ago

You did great work 💪

But I think to set the width of the #headline section to be 100% instead of 100vw.

-And I suggest to set #headline .header width to auto

NatanimA commented 2 years ago

You did great work 💪 But I think to set the width of the #headline section to be 100% instead of 100vw.

Thank you manar for your feedback , I will make the changes.

AhmedNazirMusah commented 2 years ago

Nicely done brother. But I suggest that instead of giving specific width to your paragraphs you should use 100%. This will cover the rest of the available spaces around.

https://github.com/NatanimA/Microverse-Portfolio-Project/blob/a495e993d92eba5d0f69b3cddb9f27f6c8bdd6ad/css/style.css#L204-L205

NatanimA commented 2 years ago

Nicely done brother. But I suggest that instead of giving specific width to your paragraphs you should use 100%. This will cover the rest of the available spaces around.

https://github.com/NatanimA/Microverse-Portfolio-Project/blob/a495e993d92eba5d0f69b3cddb9f27f6c8bdd6ad/css/style.css#L204-L205

Thank you ahmed, I will look in to it.