search

Nate-Wessel / urban-freight

Maps for a dashboard on GHG emissions from urban freight in Canadian cities
https://www.pembina.org/urban-freight
0 stars 0 forks source link

Bike lane history #73

Closed Nate-Wessel closed 2 years ago

Nate-Wessel commented 2 years ago

I'm working toward pulling down historical bike facilities data and mapping it. Step one is to duplicate the procedure we have now for current data so I can better automate it for the past.

@jamaps I wonder if you can take a look at what I've done here and see if it aligns with how you were classifying bike facilities for the map? It seems that we had broken things down into five categories indicated by letters (P,T,L,S,O) but that we then only rendered three categories by later combining those together before rendering on the map.

I think I've largely reproduced the effectively tripartite classification, more compactly with a bit of regex. One other difference if that I'm not quite clipping to city boundaries yet.

https://github.com/Nate-Wessel/urban-freight/blob/839331a27ae9703a6c1360347f1b2ac1bdcf9c66/src/data/data-prep-utils/fetch-osm.mjs#L47-L82

Though somehow the map seems too cluttered so I think I'm still missing something.

jamaps commented 2 years ago

Thanks! I have this flagged, but probably won't be able to get to it until early next week

Nate-Wessel commented 2 years ago

If the classification looks good / the same, feel free to merge in. I'll keep working on the data update script, but that won't effect the maps (except for the updated data) until a bit further on.

Nate-Wessel commented 2 years ago

That timing is something I'll play with more too - we'll have to once we start requesting a ton of history data.

jamaps commented 2 years ago

I'm able to fix the timeout failure, just by adding a delay between the boundary query and the bike feature query