search

Nate711 / DJIPupperTests

MIT License
7 stars 8 forks source link

backlash parameter units error #10

Open akrolic opened 1 year ago

akrolic commented 1 year ago

Hello,

Was reviewing the code on master and noticed the backlash parameter was not properly converted into radians. Should be 2/180. I could be mistaken, but this should be an easy fix. https://github.com/Nate711/DJIPupperTests/blob/c6f2cd8e15e33d0188c955ba07c7703e88bb51f7/src/DriveSystem.cpp#L33

Cheers, akrolic

akrolic commented 1 year ago

Actually following up on this it really ought to be 2 * PI / 180 assuming the backlash is parameterized to be 2 deg. I dont know how this value of 2/80 came to be but it seems like a mistake to me.