NateLaugh / 1485-a01-web-type-zealots

GDMA1485 Web Type Zealots Single Page Site Assignment
0 stars 0 forks source link

critique #3

Open ghost opened 10 years ago

ghost commented 10 years ago

try spacing out your elements to increase readability and the ability to find things

on lines 28 and 29 h3 Web Design is 95% Typography h3 h5 by Oliver Reichenstein h5 this isn't semantically correct after an h3 you would need h4 not h5

all apostrophes and quotes need to be replaced with special code

line 74 you forgot to close the link with

try different colors they are causing too much vibration and inhibiting readability. If you want to stick with white try an off white for the background

your copyright isn't aligned to the rest of the page

style the dl there is way too much space

don't create multiple types of elements for each thing you have 3 p elements in your css when you can combine them into 1

this is needed or your site will be over 100% body {margin: 0; padding: 0;}

elladurham commented 10 years ago

I agree with @JaidRose about the colors, they are pretty high contrast. However, at least you are using color sparingly which is good in this case. I'd suggest either lightening up the body copy slightly or experimenting with off whites.

Also, this color combo screams BRONCOS to me. I'm not sure that really communicates 'type snobs.' Style your <a> elements, leaving them default makes them seem unconsidered.