search

NateLaugh / web-iv-portfolio-site

Web IV Portfolio Sites
0 stars 0 forks source link

Cleanliness of Code #1

Open TheDanAlatriste opened 9 years ago

TheDanAlatriste commented 9 years ago

Advanced - The code is very clear and organized and its easy to read through.

elladurham commented 9 years ago

Looking very consistent in formatting.

A couple of things to look into. You shouldn't have to assign a class to make something only visible at one screen size and then hidden for all of the other screen sizes. For example, line 13 of index.html could be <nav class="tablet visible-for-medium-only"> instead of <nav class="tablet visible-for-medium-only hidden-for-large hidden-for-small"> also I think there might be a better way of going about making your navigation responsive than showing and hiding two separate sets of markup.

elladurham commented 9 years ago

Use shorthand in your css when you can. Like on line 28 of custom.css

#about {
    padding-top: 350px;
    padding-bottom: 350px;
}

could be 

#about {
    padding:350px 0;
}
elladurham commented 9 years ago

Make sure you are not UPPERCASING COPY IN YOUR MARKUP, you can use text-transform instead in css to make it uppercase, but if you make it so in your markup you don't have any stylistic control over it and it might change the meaning in a screen reader.