NateLaugh / web-iv-portfolio-site

Web IV Portfolio Sites
0 stars 0 forks source link

Semantics #6

Open TheDanAlatriste opened 9 years ago

TheDanAlatriste commented 9 years ago

Satisfactory - Elements are used when they're supposed to, like having the contact and about in their own sections. The naming of some of the "ID"s and "class"s are descriptive, like "brand-heading" and "tablet-l" but some parts need to have more descriptive parts. There are also no "h1"s on either page, so that messes up the rest of the h elements that you use.

elladurham commented 9 years ago

@TheDanAlatriste is right, it's important to have an <h1> in the document.

Be careful of numbering things like classes, try to give them a more semantic meaning than a number. For example .social-1 or .form-contact-1 or .project-1