NateRickard / Plugin.AudioRecorder

Audio Recorder plugin for Xamarin and Windows
MIT License
164 stars 68 forks source link

Updated NuGet packaging for VS 2019 #58

Open Haarmees opened 3 years ago

Haarmees commented 3 years ago

Hello, While testing for #57 I wanted to be able to publish the plugin to a local feed and import it from there. I don't have VS 2017 so I wasn't able to use nugetizer3000. That's why I changed the Plugin.AudioRecorder.NuGet project to work with msbuild /t:pack and I thought I'd share it here. As an example I used https://docs.microsoft.com/en-us/nuget/guides/create-packages-for-xamarin.

With this update you should be able to right click the nuget project and click "pack". The *.nupkg file can then be found in the bin folder and published. You can also use msbuild /t:pack from the command line.

Haarmees commented 3 years ago

@NateRickard Thanks again for this plugin. Will you be able to merge this and the other PRs? The plugin still seems pretty popular. If you want I can help with maintaining this plugin.

NateRickard commented 3 years ago

Thanks for the ping... I'm definitely interested in this PR - I lost my xplat setup that was configured to use the Nugetizer, and I hadn't found the time to update to something like this. I'm not working in mobile anymore, so if you're using the plugin and can help review PRs, issues, etc. I'd definitely be open to that!

Haarmees commented 3 years ago

I'm glad to help. I'm currently planning to use the plugin at work, with the adjustments from #57. (We are recording sensitive data, so we rather not store it on the device.) I also have access to an iPhone and android devices, so testing new code shouldn't be a problem.

NateRickard commented 3 years ago

I was hoping that VS Mac could load your updated packaging solution, but alas it doesn't support that project type. I no longer have my Windows machine, so I'll have to configure a VM to get this approved, merged, and get a package out.

Haarmees commented 3 years ago

Yeah, I don't think you can build UWP on mac. I do have a windows machine available, so I could build it if you want. You can also contact me on discord haarmees#9624 if that is easier.

LGE-AUGMENSYS commented 3 years ago

@NateRickard @Haarmees Many thanks for your effort. Just want to ask if there's any update on this. We encountered this bug also on some other devices and it got fixed by #43. So it would be great to get an update of the Nuget package.