search

NateWr / business-profile

WordPress plugin to display your business's contact details with seo-friendly Schema.org markup.
34 stars 16 forks source link

En Dash Time Separator #45

Closed tomkenkel closed 8 years ago

tomkenkel commented 8 years ago

This is my first ever pull request for anything. Hope I’m doing it right. You’ve got a good little plugin, thank you. This will make the time separators look more professional.

“Use close-set* en dashes… between digits to indicate range.” —Elements of Typographic Style (pg 80)

Only way to do that without more js/css is with  

The – is critical, the thin space not as much.

NateWr commented 8 years ago

Thanks @tomkenkel. This looks good. Can you also make the change for this separator and add it to the PR?

https://github.com/NateWr/business-profile/blob/master/includes/template-functions.php#L319

NateWr commented 8 years ago

Hi @tomkenkel. Sorry I'm just now seeing that you added the extra changes to the PR. GitHub doesn't notify me just from the commit.

Due to some pretty significant changes to the code base (I merged multi-location support yesterday), there were some gnarly merge conflicts. So I just re-implemented your changes in my own commit.

https://github.com/NateWr/business-profile/commit/074a9e2d5101308eb9066868d37285ef27dade18

Thanks for contributing!