search

NateWr / business-profile

WordPress plugin to display your business's contact details with seo-friendly Schema.org markup.
34 stars 16 forks source link

WP Coding Standards Cleanup #52

Closed robneu closed 8 years ago

robneu commented 8 years ago

Most of this is pretty trivial, but should help keep the overall codebase as close to the current WPCS as possible. There are still a few outstanding issues related to escaping but I didn't want to go through and escape everything due to the fact that it may cause display issues with the output.

Since you're more familiar, it would probably be a better idea for you to escape the values that you know are not already escaped elsewhere before being output.

These changes are untested and should be applied and tested before release. I don't think I touched anything that would impact functionality, but it's entirely possible. One thing in the JS file is definitely iffy and I noted it in the commit.

If you have any questions about any of the changes or want me to adjust anything, just let me know.

NateWr commented 8 years ago

Thanks Rob! Shipping tomorrow!

robneu commented 8 years ago

Sweet! Glad I could help. :D