NathanGrenier / SOEN-341

Web Project for Concordia's SOEN 341 Class (Software Process)
https://soen-341.vercel.app
1 stars 2 forks source link

Reservation schema extension, implement check in/out #200

Closed briantkatch closed 6 months ago

briantkatch commented 6 months ago

🛠 Proposed Changes:

This commit adds the following additonal fields to the Prisma schema:

@NathanGrenier might need your assistance to make the migration go smoothly in develop/prod as existing reservations will need to be dropped for not having a credit card number. See the migration.sql file.

📝 Details:

Prismaliser diagram:

prismaliser-3

github-actions[bot] commented 6 months ago

Vercel Preview URL :rocket: : https://soen-341-5orr1cr1y-nathangreniers-projects.vercel.app Neon branch :elephant: : https://console.neon.tech/app/projects/shiny-smoke-03744977/branches/br-old-voice-a5ecwyqo

NathanGrenier commented 6 months ago

@NathanGrenier might need your assistance to make the migration go smoothly in develop/prod as existing reservations will need to be dropped for not having a credit card number. See the migration.sql file.

Them being dropped isn't an issue if that's the only possible solution (we currently have 0 reservations on develop and main).

Prisma has a section on their docs explaining data migrations. From what I've read, it seems like we can use the process they described to populate the new columns.

briantkatch commented 6 months ago

Prisma has a section on their docs explaining data migrations. From what I've read, it seems like we can use the process they described to populate the new columns.

@NathanGrenier The link points to an LTT video, but I understand there are some options for default values. In this case, it's probably easiest to just drop the reservations, and ideally get the seed data loaded into dev/prod.

NathanGrenier commented 6 months ago

@NathanGrenier The link points to an LTT video, but I understand there are some options for default values.

My bad, that was a link for my brother. I've updated the link in the original comment.

In this case, it's probably easiest to just drop the reservations, and ideally get the seed data loaded into dev/prod.

You can try the data migration or just drop the table, whatever works for you.

briantkatch commented 6 months ago

Getting a 500 error viewing the dashboard using both the rep and customer account that I can't reproduce on my local machine @NathanGrenier

Gonna need some Vercel logs to poke into that any further...

Otherwise this feature is done @CarciDev

briantkatch commented 6 months ago

Still seeing that 500 @NathanGrenier @CarciDev

If I do a browser reload of the page, I can actually see the dashboard before the 500 pops up... combined with the fact that I don't see any actual 500 requests in the browser log, I'm guessing it's a Vercel-specific issue or a Svelte crash of some kind...

The Vercel logs posted to Discord don't show any indicators other than possibly an incomplete deployment of some kind (eg. why is the vercel flog not there)? No 500s in the Vercel log that was posted.

https://github.com/NathanGrenier/SOEN-341/assets/10686291/ce0200c0-9c85-496c-b515-29fa5df24544

NathanGrenier commented 6 months ago

Fixed issue. See this commit for the fix.