search

NathanRoyer / pitch_shift

pitch-shifting using the phase vocoder technique
5 stars 2 forks source link

Idea: add additional constructor taking frame size #2

Open stephanemagnenat opened 2 years ago

stephanemagnenat commented 2 years ago

Currently the constructor takes a window duration in ms, which is nice for the user, but typically would not lead to a well-aligned frame_size (such as 1024 or 2048), which might prevent some optimization in the underlying FFT library.

A solution could be to add a "lower-level" constructor taking the frame_size directly and having the current one calling that other one.

NathanRoyer commented 1 year ago

I don't have the time to work on this right now but you are totally right; your solution is also appropriate.