[Android Bootcamp] Project 3: Finch - Ready for review

[NathanSass]

The basic required stories have been completed and archived onto an mvp branch. I continued to add features on the master branch. Please review. /cc @codepathreview @codepath

[codepathreview]

:+1: Great work overall! A few notes after checking out the code:

• Good to see you were able to format the timestamp cleanly (consider using the short format - 8m, 7h, etc.)
• Good to see you refreshed the timeline after composing a new tweet
• Nice touch with the character count being displayed while the user composes a tweet
• Nice to see you used a SwipeRefreshLayout library for easy timeline refreshes
• Glad to see you made the compose activity into a dialog instead
• Good to see you added ORM annotations to the models
• Great job embedding media image in tweet object
• Good job adding offline support
• Nice to see you were able to successfully add and use Vector Drawables
• Consider adding progress bars to your app whenever a network request goes out

Here's a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, ActionBar, Navigation, Models, Authentication, API Communication, Persistence, et al) and see how they all fit together. We are close now to a turning point in the course where you should be hitting a "critical mass" towards your knowledge of Android.

[NathanSass]

@codepathreview @codepath

Thank you so much for the feedback! I have a few questions

1. For my compose fragment, how do I get rid of all of the spacing around it and have it fill the whole screen?
2. How do I use the short time format? I looked through the other methods but couldn't find that one. And it looks so nice!
3. For my tweet detail activity, I had a lot of trouble getting the content_tweet.xml to layout below the toolbar in activity_tweet. I ended up using margin-top :/
4. I did actually use some progress bars, but the calls were coming in super fast so they didn't render.
5. Are fragments ever just avoided outright, they seem to have many eccentricities and I'm not sure what benefits they have.

[codepathreview]

@NathanSass, thanks for the follow up. Here are some pointers

1. You can refer here for more details and play around with the sizing.
2. There are many ways of doing it, people generally end up writing their own algorithm based on the time difference from current time and then formatting the string accordingly.
3. Did you refer this guide for the toolbar usage?
4. Ah, that's good 👍
5. You will learn more about Fragments in upcoming lectures and learn its advantages over 'Activities`. Main advantage is re-usability of UI.

Let us know if you have further questions.