Closed bschilder closed 1 year ago
Just pushed this fix @Al-Murphy
@bschilder seems to have failed the GHA, can you look into it and check if it's a real fail or something strange - I'll push upstream if it appears to be a strange GHA issue
Ok, so it seems that the checks passed on Linux and Windows, but not Mac again. I think this is some image rendering issue with knitr on GHA's Mac machines.
So it's unrelated to my updates, but would nevertheless be good to figure out why it keeps happening!
"``{r, error=TRUE}" at the top of code chunk and adding
try()` doesn't seem sufficient to avoid this. Can't think of another way besides not running those code chunks at all.
The GHA issue has since resolved itself
Originally came up here: https://github.com/neurogenomics/MAGMA_Celltyping/issues/107
Basically, if a ctd doesn't have the matrix "specificity_quantiles" in it to begin with, it won't be generated by
EWCE::standardise_ctd
due to how I now iterate over existing matrices (not hard-coded predetermined ones).I'll modify this and re-standardise the CTDs in
MAGMA.Celltyping
releases.Reprex
Session info