search

NathanSkene / EWCE

Expression Weighted Celltype Enrichment. See the package website for up-to-date instructions on usage.
https://nathanskene.github.io/EWCE/index.html
53 stars 25 forks source link

Dendrogram not reordering cell types in plot #88

Closed Al-Murphy closed 8 months ago

Al-Murphy commented 8 months ago

1. Bug description

When ewce_plot() is run with make_dendro = TRUE, the resulting column order in the $withDendro output plot is the same as the plain plot meaning there is no update to the cell type orders based on the dendrogram. It is unclear if this has always been the case or is a bug introduced by the refactoring.

Adding a fix and a unit test for this now and will push to both the release and dev branch.

Al-Murphy commented 8 months ago

The issue only affected cases where there was no plotting values in the ctd i.e. no value in ctd[[annot_level]]$plotting.

Fix implemented in v1.11.1 and release v1.10.1