NathanWalker / angular-seed-advanced

Advanced Angular seed project with support for ngrx/store, ngrx/effects, ngx-translate, angulartics2, lodash, NativeScript (*native* mobile), Electron (Mac, Windows and Linux desktop) and more.
MIT License
2.26k stars 451 forks source link

fix android starutp splash screen #443

Closed llwt closed 7 years ago

llwt commented 7 years ago

This pulls in the splash screen assets for android from the tns create command.

Related docs: https://docs.nativescript.org/publishing/creating-launch-screens-android

The two questions I have here are:

NathanWalker commented 7 years ago

@llwt thank you! I think we can keep those in styles.xml since it would be consistent with latest template project settings as well as colors. Just looking at travis build failure.

llwt commented 7 years ago

Weird, is there a way to rerun the travis build? The error seems unrelated to the changes:

[00:21:13] 'build.html_css' errored after 1.68 s
[00:21:13] Error: Node Sass does not yet support your current environment: Linux 64-bit with Unsupported runtime (57)
For more information on which environments are supported please see:
https://github.com/sass/node-sass/releases/tag/v4.5.2
    at module.exports (/home/travis/build/NathanWalker/angular-seed-advanced/node_modules/node-sass/lib/binding.js:13:13)
    at Object.<anonymous> (/home/travis/build/NathanWalker/angular-seed-advanced/node_modules/node-sass/lib/index.js:14:35)
    at Module._compile (module.js:569:30)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:503:32)
    at tryModuleLoad (module.js:466:12)
    at Function.Module._load (module.js:458:3)
    at Module.require (module.js:513:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/home/travis/build/NathanWalker/angular-seed-advanced/node_modules/gulp-sass/index.js:187:21)
NathanWalker commented 7 years ago

Looks like a travis issue thank you for this @llwt !