search

NathanWalker / angular-seed-advanced

Advanced Angular seed project with support for ngrx/store, ngrx/effects, ngx-translate, angulartics2, lodash, NativeScript (*native* mobile), Electron (Mac, Windows and Linux desktop) and more.
MIT License
2.26k stars 451 forks source link

Add npm lock file for npm 5 #451

Open renestalder opened 7 years ago

renestalder commented 7 years ago

I'm submitting a ...

[ ] bug report
[x] feature request
[ ] support request

Current behavior npm modules are installed via version specified in the package.json, where when installed with yarn, the version are taken from the yarn lock file. This is the normal behaviour with npm lower than version 5.

When installed with npm, the versions can vary between developers and this causes unexpected errors.

Expected behavior It should install a locked version number. This is possible with npm 5 and the npm lock file, which is similar to yarn.

Minimal reproduction of the problem with instructions No specific case, but happened to me with the TypeScript version.

What is the motivation / use case for changing the behavior? Less unexpected errors

Please tell us about your environment: macOS

NathanWalker commented 6 years ago

Hi @renestalder thanks for the report - I"ll fix this once {N} supports angular 2.4 and I can update more of the seed: https://github.com/NativeScript/nativescript-angular/pull/842

danielgek commented 6 years ago

@NathanWalker do you mean 4.2 ? xD