NathanWalker / angular-seed-advanced

Advanced Angular seed project with support for ngrx/store, ngrx/effects, ngx-translate, angulartics2, lodash, NativeScript (*native* mobile), Electron (Mac, Windows and Linux desktop) and more.
MIT License
2.26k stars 451 forks source link

TS compile error in sample component #452

Closed pavlovich closed 6 years ago

pavlovich commented 7 years ago

I'm submitting a ... (check one with "x")

[X] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, instead see use [gitter](https://gitter.im/mgechev/angular2-seed) or [stackoverflow](https://stackoverflow.com/questions/tagged/angular2)

Current behavior

On a clean clone of the project, during the app startup (executing 'npm run start.deving'), the following Typescript compilation errors are displayed in the console:

/Users/pavlovich/projects/udc/registry/src/client/app/modules/sample/effects/sample.effect.ts(20,41): error TS2684: The 'this' context of type 'Actions' is not assignable to method's 'this' of type 'Observable'. Types of property 'lift' are incompatible. Type '(operator: Operator<any, Action>) => Observable' is not assignable to type '(operator: Operator<any, R>) => Observable'. Types of parameters 'operator' and 'operator' are incompatible. Type 'Operator<any, R>' is not assignable to type 'Operator<any, Action>'. Type 'R' is not assignable to type 'Action'. /Users/pavlovich/projects/udc/registry/src/client/app/modules/sample/effects/sample.effect.ts(31,40): error TS2684: The 'this' context of type 'Actions' is not assignable to method's 'this' of type 'Observable'.

Expected behavior

The errors reported above would not be present in the console.

Minimal reproduction of the problem with instructions

  1. Clone a fresh copy of the repo.
  2. npm install
  3. npm run start.deving
  4. Observe the errors in the console.

What is the motivation / use case for changing the behavior?

Provide a clean sample app to be used as a reference for further development

Please tell us about your environment:

Mac OSX Sierra Node 6.11.0 NPM 3.10.10

[486dc0c]

renestalder commented 7 years ago

See #450