search

NathanWalker / angular-seed-advanced

Advanced Angular seed project with support for ngrx/store, ngrx/effects, ngx-translate, angulartics2, lodash, NativeScript (*native* mobile), Electron (Mac, Windows and Linux desktop) and more.
MIT License
2.26k stars 451 forks source link

Angular 5.1.x update missing @angular/service-worker/build/gulp #478

Open garrettH3S opened 6 years ago

garrettH3S commented 6 years ago

This module no longer contains this method. How can I update this file to work with angular 5.1.x?

https://github.com/NathanWalker/angular-seed-advanced/blob/2d652e157a4841830f616fbc9be69d8fddf2ae2e/tools/tasks/seed/sw.manifest.static.ts#L2

m-abs commented 6 years ago

Did you find a solution? I'm having the same problem?

m-abs commented 6 years ago

I'm answering myself: I downloaded https://github.com/angular/mobile-toolkit/blob/master/service-worker/worker/src/build/gulp.ts placed it in tools/utils, made a few minor fixes to make typescript accept it.

garrettH3S commented 6 years ago

@m-abs I haven't found a solution yes. I removed the gulp job in the interim, I assume you cloned the mobile-toolkit down and imported it?

m-abs commented 6 years ago

Yes, just that one file. Typescript complaint about a few things, that I fixed.

I probably could just have deleted the task, we don't use service-workers (yet).