search

NathanWalker / nativescript-fancyalert

Fancy alerts for NativeScript.
Other
147 stars 38 forks source link

[Docs] Update readme to reflect updated function signatures #54

Closed dcarrot2 closed 5 years ago

dcarrot2 commented 6 years ago

Thanks for the awesome library! While working with fancyalert, I noticed that the readme has not been updated to reflect updated function signatures.

README.md

...
showWarning(title: string, subTitle?: string, closeBtnTitle?: string, duration?: number, width?: number)
...
...
static showWarning(
    title: string,
    subTitle?: string,
    closeBtnTitle?: string,
    duration?: number,
    width?: number,
    buttons?: Array<TNSFancyAlertButton>
  ): Promise<{}>;
...

Would you take a contribution to address this?

NathanWalker commented 6 years ago

Thanks yes definitely :)