search

NathanWalker / nativescript-loading-indicator

Progress/Loading indicator with options for NativeScript. iOS + Android.
Apache License 2.0
112 stars 41 forks source link

Fixed typo that prevents status from being updated after progressDialog is shown on Android. #51

Closed digi-chris closed 5 years ago

digi-chris commented 6 years ago

When creating a loader object, you can pass parameters through, including a message:

var options = { message : "This is the first message." };
loader.show(options);

However, when updating the message later with the loader already shown on screen, nothing happens:

options.message = "Message changed!";
loader.show(options);

This appears to happen because there is a typo in /src/android/progress-dialog.ts - _progressDialog.setMessage on line 26 is written as _progressDialog.setMesssage (three 's' characters).

NathanWalker commented 5 years ago

Thank you @digi-chris long overdue - looks like 2 fixes had been posted for this: https://github.com/NathanWalker/nativescript-loading-indicator/pull/47