Error when not specifying any color on the options

NathanWalker / nativescript-loading-indicator

Progress/Loading indicator with options for NativeScript. iOS + Android.

Apache License 2.0

112 stars 41 forks source link

Error when not specifying any color on the options #66

Closed danielgek closed 5 years ago

danielgek commented 5 years ago

https://github.com/NathanWalker/nativescript-loading-indicator/blob/5f0d07f291120d74140efd414262ce24a6127524/src/loading-indicator.android.ts#L51

as you can see on that line if i don't specify a text color in options it will try to user android as color which is not a valid color, maybe change android to black as default ?

RacknerFrank commented 5 years ago

@NathanWalker any fix on the horizon for this? Without passing options the app will just crash on android if you add this plugin

18clans commented 5 years ago

I ran into this issue and could not figure out what it was since I did not specify a default color. It kept throwing Error: Invalid color: android

NathanWalker commented 5 years ago

Thank you for reporting this @danielgek fixed in 2.5.2 now.