fix(statically-loading) Use OpaqueToken for providing config

NathanWalker / nativescript-ngx-fonticon

Use custom font icon collections seamlessly with NativeScript + Angular.

MIT License

76 stars 39 forks source link

Closed hypery2k closed 7 years ago

hypery2k commented 7 years ago

see #15

NathanWalker commented 7 years ago

Thank you @hypery2k very much! I'll bump and release this in a moment. I'm not crazy about the USE_STORE token - not sure that's absolutely needed?

hypery2k commented 7 years ago

I don't think we need the token, but the ngc compile is needed due to the needed metadata

hypery2k commented 7 years ago

the token is needed and the ngc compile is needed. Should I make a new PR and a PR for #22? Would be easier to verify for other

NathanWalker commented 7 years ago

Thanks @hypery2k ok cool yes that would be greatly appreciated. I was having trouble with the previous PR, ended up having to strip it back.