search

NathanWalker / nativescript-ngx-fonticon

Use custom font icon collections seamlessly with NativeScript + Angular.
MIT License
76 stars 39 forks source link

Use angular compiler to generate metadata #26

Closed hypery2k closed 7 years ago

hypery2k commented 7 years ago

see #15

hypery2k commented 7 years ago

I just not wanted to complicate the demo app. For now it's okay with the second app, as I can reproduce the issue there. Before merging all of this, let's discuss what and how we merge it, ok?

The PR ist still WIP

hypery2k commented 7 years ago

the latest commit seems to work so far with AoT enabled. @NathanWalker We need the compiler-cli and USE_STORE OpaqueToken to make it work. Regarding the sample app: To verify that's all working I need to complete decoupled ng2-nativescript app with AoT enabled. So sadly to say, we need a second one, but I would like to move it to test-feeder. Would this be ok for you? If you have any further questions you'll reach we in the nativescript slack

NathanWalker commented 7 years ago

@hypery2k does this PR contain fixes you feel provide AoT ability?

hypery2k commented 7 years ago

I've verified it's working in two of my TNS projects and also some users reported it's working as it is

hypery2k commented 7 years ago

@NathanWalker Some Metadata was ignored in npmignore which leads besides the closures to issues. I've verified that with my latest changes it's working. Should I make release?

hypery2k commented 7 years ago

@NathanWalker The latest changes seems to work as in #15 mentioned. Should I make a minor release or do you want to purge and release?

hypery2k commented 7 years ago

@NathanWalker: Should I make a new release? it seems to work without and with AoT now, see https://github.com/NathanWalker/nativescript-ngx-fonticon/issues/15#issuecomment-295252875