NathanWalker / nativescript-ngx-fonticon

Use custom font icon collections seamlessly with NativeScript + Angular.
MIT License
76 stars 39 forks source link

Bug: can't use 'fa-glass' from FontAwesome 4.7.0 due to a minor parsing error. #31

Open m-abs opened 6 years ago

m-abs commented 6 years ago

I found a minor parsing error for FontAwesome 4.7.0 css.

I couldn't use fa-glass in my demo app, this is the output from enabling debug:

JS: Collections to load: fa
JS: ----------
JS: Loading collection 'fa' from file: ./assets/font-awesome.css
JS: Angular is running in the development mode. Call enableProdMode() to enable the production mode.
JS: *FontAwesomeusestheUnicodePrivateUseArea(PUA)toensurescreen
JS: readersdonotreadoffrandomcharactersthatrepresenticons*/
JS: .fa-glass: \uf0000
JS: fa-music: \uf001

As you can see fa-glass is prefixed with a dot.

This is caused by a two line comment in the font-awesome.css from v4.7.0 just before .fa-glass {...} Removing those two lines fixes the problem and can be used as a workaround.