search

NathanWalker / nativescript-ngx-fonticon

Use custom font icon collections seamlessly with NativeScript + Angular.
MIT License
76 stars 39 forks source link

Request: accept .scss file in config #34

Closed denkan closed 6 years ago

denkan commented 6 years ago

I'm using .scss files in my code base, meaning I'm also .gitignore all generated .css files. This makes it troublesome to have a font-awesome.css file.

Tried to rename to .scss but TNSFontIconModule.forRoot() config won't accept it.

Perhaps it could?

EddyVerbruggen commented 6 years ago

But if the fontawesome css file actually css them it’s a waste or resources to have the Sass compiler parse that (probably) large file.

Can you not just make an execption in your .gitignore? “!path/to/font-awesome.css” should do it.

denkan commented 6 years ago

The fontawesome.scss itself shouldn't be compiled because it's not imported into any actually used file. Or am I missing something - does all .scss files get somewhat compiled?

But good tip about exception - fair enough :)