search

NathanY3G / rp2040-pio-emulator

RP2040 emulator for the testing and debugging of PIO programs
Apache License 2.0
44 stars 7 forks source link

Add type-hints to source code #79

Closed NathanY3G closed 1 year ago

NathanY3G commented 1 year ago

Please add type-hints to the source code. This should help to document the code and make it easier for both users and contributors.

aaronjamt commented 1 year ago

Any way I can help with this?

NathanY3G commented 1 year ago

Any way I can help with this?

Sure! The first pass is mostly done but if you are really keen then please let me know and we can share the work. It may not be the most interesting task but it should help everyone who is interested in this project :slightly_smiling_face:

aaronjamt commented 1 year ago

I've looked through the code but I think you've added hints to all the functions. Is there actually any more to do still?

aaronjamt commented 1 year ago

I submitted #83, hopefully that helps

NathanY3G commented 1 year ago

Thanks @aaronjamt for helping with this :slightly_smiling_face:

P.S. GitHub automatically closed your PR before it was merged! I suspect this occurred because both of the branches were named the same. I created a new PR to include your changes. However, if you believe any of your commits are missing then please let me know.