NathanaelA / nativescript-exoplayer

Please use: https://github.com/nstudio/nativescript-plugins/
27 stars 36 forks source link

TS Compile and Crash Fixes #25

Closed DickSmith closed 6 years ago

DickSmith commented 6 years ago

Several fixes. Android Crash, same as #23, that I'd been sitting on for a few weeks. iOS crash described here: https://github.com/NathanaelA/nativescript-exoplayer/commit/c965295dceca10547c126723cd009b0c2bc4ac62

I was getting a lot of compile errors when I tried to build this and it seemed like it was missing some d.ts and had some typing problems. Other than the changes for the 2 crashes all other changes should have no functional impact, just typing and tsc related. For the d.ts, I used a slightly modified version of the ones from Brad's player for videoplayer.d.ts and video-source.d.ts and then generated and cleaned up the one for subtitle-source to follow the same general pattern.

NathanaelA commented 6 years ago

Thanks and pushed in 3.4.1