search

NathanaelA / nativescript-permissions

Wraps up the entire Android 6 permissions system in a easy to use plugin.
MIT License
46 stars 22 forks source link

Update permissions.android.js #39

Closed aaron-burke closed 5 years ago

aaron-burke commented 5 years ago

Checks if androidx is undefined. This fixes the problem I am getting, as you mentioned - you tested both ways - so not sure why I get this issue but you didn't. I guess use this only if others also see the issue? If you would like me to send you details on this demo setup I am trying I can do. Quick info is v2 demo-ng of nativescript plugin: webRTC... Using Emulator API 27 (Android 8.1) and also Samsung Galaxy Tab S3

aaron-burke commented 5 years ago

New update fixes this

NathanaelA commented 5 years ago

I have uploaded v1.3.6 that fixes it, but again thanks for your PR -- looks like we came up with slightly different solutions. Thank you for bringing up the issue, I'm glad to get it fixed asap!

The only thing I can think of is that I tested it on normal (supportv4 app) with the hasSupportv4 as the first if statement; and so it worked as it never got to do the hasAndroidx check. Then later as I was cleaning some stuff up; I realized that hasAndroidX should be first because come NS6 it will be the standard method. By that time I was already using the AndroidX emulator, so I never realized that I messed everybody up. LOL.

aaron-burke commented 5 years ago

Thanks for for your time and fast response.