Android - update to Java-WebSocket-1.3.4, add subprotocol support, and workaround onClose READYSTATE issue

NathanaelA / nativescript-websockets

Websockets for NativeScript

83 stars 43 forks source link

Android - update to Java-WebSocket-1.3.4, add subprotocol support, and workaround onClose READYSTATE issue #30

Closed john-e-riordan closed 6 years ago

soulfly commented 6 years ago

Hi @john-e-riordan do you use this version in your existing projects? I mean is it quite stable to use? I have the same issue https://github.com/NathanaelA/nativescript-websockets/issues/35 you addressed and would like to use your PR

john-e-riordan commented 6 years ago

Hi @soulfly. Currently using this version in a single production project and it is stable - Android and iOS. Started getting some PocketSocket related compile time warnings building with latest NativeScript which are annoying but apparently harmless. And empirically there are some subtle behavior differences between the Android and iOS implementations, but nothing shocking.