search

NathanaelA / nativescript-websockets

Websockets for NativeScript
83 stars 43 forks source link

Fixed issue when wrapper became null during close. #68

Closed DjOli-zz closed 5 years ago

DjOli-zz commented 5 years ago

I am using this library as the basis on a project using websockets for STOMP communication. I have experienced an issue which appears to be related to closing the socket, likely a side effect of using this library under the STOMP library, where essentially the wrapper becomes null at some point between the if check and the timeout execution. I understand you are no longer supporting advancement of this library, so I implemented a very small fix to this issue, which I don't believe will cause any problems elsewhere, and will alleviate my issue. Thanks for taking the time to review the change, and please let me know if you would rather I tidy it a little more.

NathanaelA commented 5 years ago

Looks like a good fix. Thanks. Will try and push another version to npm later...

DjOli-zz commented 5 years ago

Thanks :)

DjOli-zz commented 5 years ago

Any update on when you'll be able to push up the new release?

DjOli-zz commented 5 years ago

@NathanaelA Any update?

NathanaelA commented 5 years ago

@DjOli - Sorry for the delay; have been swamped trying to handle the proplugins.org stuff. I have published the new version...