search

NathanaelA / nativescript-websockets

Websockets for NativeScript
83 stars 43 forks source link

Update Java-WebSockets to 1.5.1 #89

Closed nikoTM closed 3 years ago

nikoTM commented 3 years ago

Breaking changes:

EDIT:

Updated jar taken from here Java-WebSocket-1.5.1-with-dependencies.jar

nikoTM commented 3 years ago

@NathanaelA

Since Java-WebSockets seems to be using SLF4J for logging, this build will log the following errors:

System.err: SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
System.err: SLF4J: Defaulting to no-operation (NOP) logger implementation
System.err: SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.

Can be solved by adding a gradle dependency with

implementation group: 'org.slf4j', name: 'slf4j-simple', version: '1.7.25'

But I thought it should be left to the plugin user to decide wether or not they want that dependency.