search

Nathanllee1 / Tabify

https://tabify-app.herokuapp.com/
4 stars 1 forks source link

Progress bar #36

Closed esauerbo closed 3 years ago

esauerbo commented 3 years ago

Created a progress bar component that tracks and displays the current position in the song. Currently unstyled.

doorlay commented 3 years ago

Looks good! Approving...

Nathanllee1 commented 3 years ago

Ship it!

BSilton26 commented 3 years ago

Looks good to me, but definitely could use some styling. Maybe match the color to the general styling of the whole web app? Like that same orange shade in that background pattern. I also noticed that changing the song progress in Spotify isn't reflected in Tabify, worth looking into. Looks good otherwise though, nice job!

esauerbo commented 3 years ago

@BSilton26 thanks for the input. I realized that the since position is tracked in Webplackback.js, when it updates (ie skipping around within a song) the state of the progress bar wasn't being updated in time because the useEffect hook isn't immediate. Moving the progress bar into Webplayback will solve this, so I'll make a new PR.

esauerbo commented 2 years ago

@Nathanllee1 @doorlay Thanks!!