search

NationStates / NationStatesPlusPlus

NationStates++ improves & rewrites the look and feel of nationstates.net - providing players with easy to use tools and more data to make decisions.
MIT License
22 stars 18 forks source link

Settings UI in Antiquity theme #4

Closed hierocles closed 11 years ago

hierocles commented 11 years ago

The forum settings UI is covered by the sidebar when using the Antiquity theme.

Additionally, the Antiquity theme has an extra ad space on the top, which happens to be right where you put the settings button. So those two are overlapping.

Lastly, when using subdomains (antiquity.nationstates.net, liberal.nationstates.net, etc), NS++ doesn't work at all. I don't know if you want to work around that, or if you would rather convince NS devs to stop setting themes by subdomains.

Afforess commented 11 years ago

The forum settings UI is covered by the sidebar when using the Antiquity theme.

Alright, fixed this part.

Additionally, the Antiquity theme has an extra ad space on the top, which happens to be right where you put the settings button. So those two are overlapping.

Can you show me a screenshot? I'm not quite sure what I'm looking for.

Lastly, when using subdomains (antiquity.nationstates.net, liberal.nationstates.net, etc), NS++ doesn't work at all. I don't know if you want to work around that, or if you would rather convince NS devs to stop setting themes by subdomains.

I know. The extension has to give permissions for each domain and subdomain, and I didn't give permission for any subdomains (except for forum). I don't plan on changing it.

hierocles commented 11 years ago

Here's a picture of the ad space issue:

image

Afforess commented 11 years ago

Dang I had no idea there were ads there (combo of paid accts + adblock).

Afforess commented 11 years ago

Thanks, fixed in 1.71.