search

National-COVID-Cohort-Collaborative / Phenotype_Data_Acquisition

The repository for code and documentation produced by the N3C Phenotype and Data Acquisition workstream
60 stars 35 forks source link

Python bigquery changes #173

Closed mgkahn closed 3 years ago

mgkahn commented 3 years ago

A number of change to python script and associated files:

empfff commented 3 years ago

Thanks Michael! Because of the magnitude of the changes, we are going to create a separate directory for the GBQ Python exporter under the /Exporters folder, incorporating all of the files that you have changed + your documentation. We'll get that done ASAP and let you know when it's available.

Thanks again!

mgkahn commented 3 years ago

If you prefer that I remove the additional functionality (I’ll leave it in my local repo) so that the changes are only to allow GBQ export, I can do that instead. I need the additional functionality so that I can have a local instance of the N3C extract in my DBMS for our internal QC checks.

M

From: empfff notifications@github.com Reply-To: National-COVID-Cohort-Collaborative/Phenotype_Data_Acquisition reply@reply.github.com Date: Tuesday, January 5, 2021 at 10:56 AM To: National-COVID-Cohort-Collaborative/Phenotype_Data_Acquisition Phenotype_Data_Acquisition@noreply.github.com Cc: "Kahn, Michael" MICHAEL.KAHN@CUANSCHUTZ.EDU, Author author@noreply.github.com Subject: Re: [National-COVID-Cohort-Collaborative/Phenotype_Data_Acquisition] Python bigquery changes (#173)

Thanks Michael! Because of the magnitude of the changes, we are going to create a separate directory for the GBQ Python exporter under the /Exporters folder, incorporating all of the files that you have changed + your documentation. We'll get that done ASAP and let you know when it's available.

Thanks again!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/National-COVID-Cohort-Collaborative/Phenotype_Data_Acquisition/pull/173#issuecomment-754796922, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA557TUBRT4H6UI7CTHDTRTSYNHDPANCNFSM4VCRXEWA.

marshallclark commented 3 years ago

Hi Michael, I created another sub-directory under Exporters for the BigQuery code: PythonExporter_bigquery Thanks for the contribution! -Marshall