National-COVID-Cohort-Collaborative / Phenotype_Data_Acquisition

The repository for code and documentation produced by the N3C Phenotype and Data Acquisition workstream
60 stars 35 forks source link

missing abs( in 25-29 age category #210

Closed mgkahn closed 2 years ago

mgkahn commented 2 years ago

Issue # 209

Missing "abs(" is one age category. Causes SQL to fail.

mgkahn commented 2 years ago

Replaced birth_datetime with coalesce() to use Y/M/D_of_birth first when present. Former field is optional in OMOP CDM 5.3, latter are mandatory fields.

AdamLeeIT commented 2 years ago

Corrected the abs() for age 25-29 category

AdamLeeIT commented 2 years ago

Michael, I did some test on the change and wondering if you would be up for having a Zoom meeting to review and test more, ultimately I don't have a great GBQ testing tool other than the Google BigQuery sandbox