search

National-COVID-Cohort-Collaborative / Phenotype_Data_Acquisition

The repository for code and documentation produced by the N3C Phenotype and Data Acquisition workstream
60 stars 35 forks source link

Updates to solve a bug in BQ ODBC drivers when reading from a temp table #211

Closed jdposada closed 2 years ago

jdposada commented 3 years ago

This update creates a table in BigQuery with a random name and then reads the table to export it. There is a bug in the ODBC drivers that prevent them from reading from temp tables. The cursor was empty.

@mgkahn

kmkostka commented 3 years ago

@mgkahn, we want to make sure this doesn't break anything. Before we merge this, is this ok by your review?

mgkahn commented 3 years ago

@kmkostka : Thanks for checking in. I worked with @jdposada to create the submitted changes. For some unknown reason, the Google SIMBA ODBC drivers work differently on Linux (Stanford's execution environment) versus Windows (Colorado's execution environment). I have confirmed that the changes in Jose's PR work in both environments. There is one place where I will make a change in a later PR that Jose did not have time to incorporate before leaving for his new position in Colombia (the country, not the USA university). But the current code does work fine in GBQ using Windows and Linux VMs.

Let me know if you need me to do anything more specific than this response.

jdposada commented 2 years ago

Hi @AdamLeeIT ,

Any chance we can merge this with the master branch?

thanks,

Jose