search

National-COVID-Cohort-Collaborative / Phenotype_Data_Acquisition

The repository for code and documentation produced by the N3C Phenotype and Data Acquisition workstream
60 stars 35 forks source link

ACT MSSQL Phenotype 4 missing placeholder on patient_dimension for @cdmDatabaseSchema #215

Open DarrenWHenderson opened 2 years ago

DarrenWHenderson commented 2 years ago

https://github.com/National-COVID-Cohort-Collaborative/Phenotype_Data_Acquisition/blob/dcdfd3703e1f4654c4b39491d6256efc793a691e/PhenotypeScripts/N3C_phenotype_act_mssql.sql#L446

When updating to phenotype 4, find-replace fails to assign a schema to patient_dimension at line 446 because it lacks the placeholder @cdmDatabaseSchema.

This can cause downstream errors, if the user running the extraction has a default schema other than dbo (or w/e the @cdmDatabaseSchema should be for that site).