search

National-COVID-Cohort-Collaborative / guide-to-n3c-v1

Research with the National COVID Cohort Collaborative (N3C: https://ncats.nih.gov/n3c)
https://national-covid-cohort-collaborative.github.io/guide-to-n3c-v1/
Other
11 stars 4 forks source link

Ch. 13 ML link to VaTech for ML in N3C #191

Closed chrisroederucdenver closed 7 months ago

chrisroederucdenver commented 7 months ago

Seems like we could use a link here: data transform code repository that Blessy Antony (Virginia Tech, blessyantony@vt.edu) developed to do machine learning in N3C.

Also, the github links before and after that quote point to the same thing.

justaddcoffee commented 7 months ago

Thanks Chris for the sharp eyes

I think we did originally have a link just after the phrase "For our walkthrough, we will be creating and using a Python library repository " to this repo in N3C, but someone (Shawn I think?) pointed out that some readers of the chapter might not be able to see this, thus the github link

chrisroederucdenver commented 7 months ago

Thanks

The way I read the text, are you talking about two different code projects? Or are ml-classification-pipeline and Blessy's the same just in different places (github and N3C enclave)? In either case the enclave link might be useful even if it's locked.

Case in point, I don't have perms to the N3C repo you linked above.

justaddcoffee commented 7 months ago

The way I read the text, are you talking about two different code projects? Or are ml-classification-pipeline and Blessy's the same just in different places (github and N3C enclave)? In either case the enclave link might be useful even if it's locked.

The github repo and Enclave link are essentially the same code I believe

@oneilsh can you comment about whether we should link to (possibly 404) links to Enclave resources? I don't have strong feelings, but possibly the G2N3C people have decided an SOP here that we can follow

chrisroederucdenver commented 7 months ago

@justaddcoffee @oneilsh There's a standard for adding a lock icon to enclave resources that require permission such as these.

I have a commit (PR to follow) that includes the link to the N3C enclave repo and uses it. I removed the (IMHO) redundant github link, and it looks like this:

Screenshot 2024-02-15 at 10 14 31 AM
justaddcoffee commented 7 months ago

I have a commit (PR to follow) that includes the link to the N3C enclave repo and uses it. I removed the (IMHO) redundant github link, and it looks like this:

Sounds good to me! Thanks Chris. I just approved your PR