National-Forestry-Authority / brms

1 stars 1 forks source link

Forest Reserves: List of additional features required for the interactive map of each Forest Reserve record (Fields) #19

Open ygoex opened 1 year ago

ygoex commented 1 year ago

For each CFR record, additional data fields as follows are required:

ygoex commented 1 year ago
ygoex commented 1 year ago

We need @LeScruf to review the fields in the description.

LeScruf commented 1 year ago

@senyonjo-edward @ygoex - Here is a merged list of fields for the CFR records. @senyonjo-edward please review / edit as needed. Thx!

senyonjo-edward commented 1 year ago

@ygoex For each CFR and LFR record, additional data fields as follows are required:

NB: Please also refer to the Statutory Instrument attached/shared

senyonjo-edward commented 1 year ago

@ygoex I have sent the Statutory Instrument (SI) via email.

senyonjo-edward commented 1 year ago

Dear Yolanda,

Please find attached the Statutory Instrument legal document that I mentioned on issue #19 on the BRMS forum.

Thank you. Edward Ssenyonjo Coordinator Inventory & Surveys, National Forestry Authority Address: Plot 10/20, spring road, P. O. Box, 70863, Kampala Email: @. | @. Tel: +256 786 461 620 CG | +256 772 521 432 skype: senyonjo_edward

On Thu, Feb 23, 2023 at 12:32 PM Yolanda Goex @.***> wrote:

Assigned #19 https://github.com/National-Forestry-Authority/brms/issues/19 to @senyonjo-edward https://github.com/senyonjo-edward.

— Reply to this email directly, view it on GitHub https://github.com/National-Forestry-Authority/brms/issues/19#event-8589532586, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKGCMFCBBUBM7N4NOMSEYBDWY4VD3ANCNFSM6AAAAAAR4LTQR4 . You are receiving this because you were assigned.Message ID: @.*** com>

LeScruf commented 1 year ago

Thank you @senyonjo-edward !

ygoex commented 1 year ago

Dear Edward,

I’m afraid I’ve not been able to download the Statutory Instrument legal document, it doesn’t seem to be attached, or it’s gone missing for no apparent reason.

Could you please send it again so I can pass it to the rest of the team.

Many thanks, Yolanda

On 7 Mar 2023, at 22:27, Edward Ssenyonjo @.***> wrote:

Dear Yolanda,

Please find attached the Statutory Instrument legal document that I mentioned on issue # https://github.com/National-Forestry-Authority/brms/issues/1919 on the BRMS forum.

Thank you. Edward Ssenyonjo Coordinator Inventory & Surveys, National Forestry Authority Address: Plot 10/20, spring road, P. O. Box, 70863, Kampala Email: @. | @. Tel: +256 786 461 620 CG | +256 772 521 432 skype: senyonjo_edward

On Thu, Feb 23, 2023 at 12:32 PM Yolanda Goex @.***> wrote:

Assigned #19 https://github.com/National-Forestry-Authority/brms/issues/19 to @senyonjo-edward https://github.com/senyonjo-edward.

— Reply to this email directly, view it on GitHub https://github.com/National-Forestry-Authority/brms/issues/19#event-8589532586, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKGCMFCBBUBM7N4NOMSEYBDWY4VD3ANCNFSM6AAAAAAR4LTQR4 . You are receiving this because you were assigned.Message ID: @.*** com>

— Reply to this email directly, view it on GitHub https://github.com/National-Forestry-Authority/brms/issues/19#issuecomment-1458897214, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB4AF6VNOGKZWBVM3SW6IDW26R2ZANCNFSM6AAAAAAR4LTQR4. You are receiving this because you were mentioned.

peacog commented 1 year ago

Attaching the Statutory Instrument document.

Statutory Instrument 1998.pdf

peacog commented 1 year ago

Here is a preliminary attempt to define the Drupal content type for CFRs and LFRs. Let's review it and fill in the gaps in the next BRMS meeting.

Content type

We currently have a content type CFR Master Maps (machine name central_forest_reserve)

Q. Should we remove CFR Master Maps and replace it with a Forest Reserve (forest_reserve) content that has a Forest Reserve Type field with two possible values? YES! (LESCRUF)

Q. Edward specified some fields as dropdown text, the values to be taken from the SI document. Should these be List (text) or taxonomy reference fields? Or can they be plain text fields? I THINK TAXONOMY REFERENCE FIELDS (LESCRUF)

Q. After the initial import of CFRs and LFRS is it likely that new reserves will be added manually in the future? THERE MIGHT BE A VERY LIMITED NUMBER OF ADDITIONS (LESCRUF)

Forest Reserve content type

Field Drupal Field Type Required Multi-value Read-only Comment
Forest reserve type Taxonomy (select) Yes Yes Possible values: CFR, LFR, PR
Name Title Yes Yes
Serial number Taxonomy (autocomplete)
District Taxonomy (autocomplete)
County Taxonomy (autocomplete)
Map sheet reference Taxonomy (autocomplete) Yes
Cadastral Sheet No 1:50,000 Taxonomy (autocomplete)
Cadastral Sheet No 1:10,000 Taxonomy (autocomplete)
Boundary Plan No Taxonomy (autocomplete) Yes
Land Registration No Taxonomy (autocomplete) Yes
Gazetted Area (ha) Number (decimal) Yes
Mapped Area (ha) Number (decimal)
Total boundary length (km) Computed field Yes Computed from Total cutline length + Natural boundary length
Total cutline length (km) Number (decimal)
Natural boundary length (km) Computed field Yes Computed from Riverline + Shoreline + Protected area
Riverline (km) Number (decimal)
Shoreline (km) Number (decimal)
Protected area (km) Number (decimal)
Year Gazetted Year only
Other Gazette mentions Year only Yes
Status of boundary records Taxonomy (select)
Priority for action Taxonomy (select)
Status of boundary description Taxonomy (select)
Survey Survey paragraph Yes Multivalue paragraph dependent field available when Status of boundary description is 'surveyed'

Survey paragraph type

Field Drupal Field Type Required Multi-value Read-only Comment
Year surveyed Year only
Surveyor User
Description of survey work Text (formatted, long) Yes
List of ordered waypoints Geolayer Yes

Taxonomy vocabularies

LeScruf commented 1 year ago

Hi @peacog & @senyonjo-edward, I answered three questions in bold above - the table questions & comments we can quickly go through today?

ygoex commented 1 year ago

Once the table is complete, we would need to create a CVS for NFA. See issue #65

ygoex commented 1 year ago

Natural boundary = Protected area + shoreline + riverline. Total boundary = natural boundary + cutline.

Natural boundary and Total boundary should not be editable. These are computed fields.

ygoex commented 1 year ago

We would need to create a Paragraph type for Year surveyed and related conditional fields that are available when Status of boundary description is 'surveyed' (Surveyor name, Surveyor username, Description of survey work and List of ordered waypoints).

ygoex commented 1 year ago

For surveyors fields, we need create blocked users that are not part of the NFA any more, we create a fullname for the user entity and we relate a surveyor by the fullname.

ygoex commented 1 year ago

List of ordered waypoints: one field that uploads a kml and displays a table. This should be another GeoLayer entity reference.

ygoex commented 1 year ago

Log of actions has been already done in issue https://github.com/National-Forestry-Authority/brms/issues/21

ygoex commented 1 year ago

WIP waiting for spreadsheet in task #65 to be completed.

ygoex commented 1 year ago

We would need to cross check with these fields:

Fields for CFR (all of them are required):

~~Entered Area (ha), is a number with decimals entered by the user. Polygon Area (ha), is a number with decimals calculated from the polygon and not editable. Entered Total boundary length (km), is a number with decimals entered by the user. Polygon Total boundary length (km), is a number with decimals from the polygon and not editable. Entered Total cutline length (km), is a number with decimals entered by the user. Polygon Total cutline length (km), is a number with decimals calculated from the polygon and not editable. Entered Total natural boundary length (km), is a number with decimals entered by the user. . It could be 0. Polygon Total natural boundary length (km), is a number with decimals calculated from the polygon and not editable. It could be 0.~~

LeScruf commented 1 year ago

@ygoex I have gone through and crossed checked the above descriptors with those in the table prepared by Edward, and they have all already been incorporated as needed. Thks!

ygoex commented 1 year ago

We need to add a field to hold the CFR identifier. See related ticket #86

LeScruf commented 1 year ago

@senyonjo-edward - Edward can we use the CFR identifiers from the Statutory Instrument for this? We can discuss?

senyonjo-edward commented 1 year ago

Hi Andrew,

@ygoex We should use the FD code (Forest Reserve serial number) as the unique forest reserve identifier.

However, we could also add a column with sequential serial numbering of the forest reserves

peacog commented 1 year ago

Hi @LeScruf, @senyonjo-edward

This functionality requested in this ticket has been implemented in the new Forest Reserve content type. We will be importing the data from the spreadsheet that you are currently working on. You can however test that the content type has all of the data fields that you expect, and that the computed fields are calculated correctly. Feel free to add and edit anything you like. The data can be refreshed from the production database any time we need to, so don't be afraid to break things.

How to test

Image

Image

LeScruf commented 1 year ago

Hi @peacog , thanks for this. Edward and I will review as soon as we can. In the meantime, we think that the first tab 'CFRs' on https://docs.google.com/spreadsheets/d/1UxIPh0a-ciR-56PHblqVpwa9IMtUj3mR82WeedmU9dw/edit#gid=162492019 is getting close. You will note that the structure of this has evolved - and so it would good to also evolve the form correspondingly. This does not stop us from testing the form of course - which I hope can be done very shortly. I think its looking good! :)

Postnote: There are bugs that need ironing out - nothing major - with the current iteration, and of course the page view after editing is yet to be worked on.

peacog commented 1 year ago

Moving back to In progress to:

LeScruf commented 1 year ago

@peacog @ygoex @senyonjo-edward - the open layers map is potentially going to start getting cluttered - we need to figure out a way of how to easily keep track of different polygon layers (which is being done through layer control) - figuring out a line and colour scheme that makes sense and provides a good UI.

peacog commented 1 year ago

Hi @LeScruf @senyonjo-edward I'm reviewing the changes made to the spreadsheet. We now have three forest reserve serial numbers:

Can you also explain the new district and county columns that have been added? Thanks

peacog commented 1 year ago

Hi @senyonjo-edward @LeScruf . I've added a new taxonomy field to the Geloayer that lets you choose a layer style that controls the colour and style of the polygon for that layer.

You can add styles here: https://brms.stg.envs.utils.nfa.go.ug/admin/structure/taxonomy/manage/layer_style/overview And you can assign the style to a layer in the Forest Reserve node, for example https://brms.stg.envs.utils.nfa.go.ug/node/26139/edit

I've set a predefined list of colours, and lines can be solid, dotted, or dashed. If you want more flexibility we could change the taxonomy settings to allow you to choose any colour you want, and/or different dashed line styles. Test it when you have a chance and let me know if you have any suggestions.

Image

peacog commented 1 year ago

Hi @LeScruf - did you have a chance to look at the geolayer styles described in the previous comment? Let me know thoughts

LeScruf commented 1 year ago

hi @peacog - this is looking very good, thank you - a question is how is this exposed in a way which is straight-forward for a NFA admin to manage? Not immediately pressing - but perhaps one of several functionality areas that can be grouped in an NFA admin page view to be easily administered and adjusted going forward? Curious - did you code this up, or is there a per-existing module that does this?

peacog commented 1 year ago

It's a custom implementation @LeScruf . I created a new taxonomy vocabulary called Layer style and added color, line width and line style fields to it. A user with permission to add taxonomy terms can create layer styles here: https://brms.stg.envs.utils.nfa.go.ug/nfa-landing?destination=/admin/structure/taxonomy/manage/layer_style/overview i.e. by going to Structure > Taxonomy > Layer style image